Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier formatter #1736

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add prettier formatter #1736

wants to merge 7 commits into from

Conversation

cyberbuff
Copy link

@cyberbuff cyberbuff commented Feb 25, 2024

Fixes #1726 Added prettier as per the GitHub Issue conversation

@cyberbuff cyberbuff closed this Feb 25, 2024
@cyberbuff cyberbuff reopened this Feb 25, 2024
"no-whitespace-before-property": "error",
"operator-linebreak": ["error", "after"],
"operator-linebreak": ["error", "before"],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed operator-linebreak to before to go along with prettier formatting

Comment on lines +24 to +25
- name: Format & Lint
run: (npm run style || npm run lint) && git diff --exit-code
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified pull_request workflow to include prettier formatting. These checks cannot be made individually in separate steps because it changes the files. Hence doing it together and checking for any file changes

Comment on lines +229 to +231
options: {
fix: true
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added option to fix any linting errors

@cyberbuff cyberbuff changed the title Add formatter Add prettier formatter Feb 25, 2024
@a3957273
Copy link
Member

I'm relatively concerned by the number of files changed by this PR. If I merge it, this will cause merge conflicts with the vast number of other PRs that are available right now.

I wonder if, perhaps, it's best to wait for me to try to process all of those and then do a single large 'style' pull request.

As a side note, you probably want to not style vendor files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add Prettier
2 participants