Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection and Deselection of autobake checkbox using keyboard #1727

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

j264415
Copy link
Member

@j264415 j264415 commented Feb 20, 2024

Issue:

#1718 - Accessibility Audit for Keyboard Navigation, Screen Reader and High Zoom

As documented in this issue I am solving:

  • Selecting auto-bake settings

Code changes:

A keydown event listener was added to ControlsWaiter.mjs to replicate the mouse functionality.
It checks and uncheck's the auto-bake using the Enter or Space key.

User-facing changes:

Users can now select and deselect the auto-bake checkbox using the Enter or Space key

Replication:

  • Navigate the web page using the Tab key till you get to auto-bake.
  • Press Enter or Space to select and deselect auto-bake checkbox.

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2024

CLA assistant check
All committers have signed the CLA.

@j264415 j264415 marked this pull request as ready for review February 21, 2024 13:53
* Checks or unchecks the Auto Bake checkbox with "Enter"
* @param {Event} ev
*/
autoBakeKeyboardHandler(ev) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this solves the problem, a more accessible solution might be to replace the <span /> check implementation with a proper check input box? That way, we would get accessibility by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change I have made adds the enter key. Also there is already a input checkbox there.
The problem here is that when I use the space bar initially without my changes , the focus ends up being stolen which the prevents me reverting that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants