New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: typography #228
Open
davisLjr
wants to merge
46
commits into
master
Choose a base branch
from
feat-typography
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: typography #228
+1,435
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisLjr
requested review from
Jesus1397,
victorianastasi,
lautarorodriguez96 and
VictoriaIleanaRodriguezMora
April 9, 2024 13:15
Propiedad font-size y line-height
…to feat-typography
VictoriaIleanaRodriguezMora
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se cambian los tamaños de la tipografia de obelisco, tambien en esta branch se incluyen nuevas variantes de tipografia para rellenar los tamaños faltantes para los componentes.
Se añaden clases de font-weight, estilo italica y tambien underline para textos.
Se componentizo la tipografia en un solo componente con la finalidad que de ser necesario que el componente en un futuro sea exportado y el cambio sea mas leve.
Enlace a figma: https://www.figma.com/file/PTv4gTxQhnSgBjnda5lBsD/An%C3%A1lisis-de-componentes-%7C-2024?node-id=752%3A14378&mode=dev
Es necesario revisar este PR en todos los componentes de manera que tengamos en cuenta los cambios que este implica sobre todo el proyecto y los cambios que genera en producción.
Es necesario consultar con el equipo de diseño, que sucedera con las secciones:
Ya que estas secciones no debemos borrarlas y deben ser incluidas en el UI-KIT, al igual que se debe consultar si se deben visualizar como en bootstrap las clases que dan colores a los textos y otra consulta seria:
Las variables $display1-size a la $display4-size no se utilizan dentro de storybook,
pero si en produccion, quizas hay que darle visibilidad. "Bloque con numeros de colores"
Debido a las diferencias encontradas entre Storybook y Figma en algunos componentes, se dejan comentarios en tarjeta de Github: