refactor: se refactoriza el codigo de tipografia pasando a ser componente react #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisLjr
requested review from
Jesus1397,
victorianastasi and
lautarorodriguez96
|
No es necesario aprobarlo ahora, este PR esta creado para que el codigo no se pierda y tenerlo listo para cuando sea el momento adecuado |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se refactoriza el HTML de tipografia, pasando a ser componentes React.
Se le pueden pasar clases por props, y cada una tiene un children para poder colocar texto dentro o anidar etiquetas.
Se dejó el HTML anterior con la finalidad que al hacer el testeo, sea sencillo encontrar diferencias si es que estas existen.
La rama Refactor, esta pensada para almacenar los distintos refactor y ser un entorno de prueba antes de "master"