We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawning multiple models with DetachableJoint plugin will result in only one shared detach topic. Consider using robotNamespace like here:
gz-sim/src/systems/multicopter_motor_model/MulticopterMotorModel.cc
Line 376 in 6af7445
gz-sim/src/systems/detachable_joint/DetachableJoint.cc
Line 98 in 6af7445
std::string robotNamespace = this->model.Name(_ecm); if (_sdf->HasElement("robotNamespace")) { robotNamespace = _sdf->Get<std::string>("robotNamespace"); } // Setup detach topic std::vector<std::string> detachTopics; if (_sdf->HasElement("detach_topic")) { detachTopics.push_back(transport::TopicUtils::AsValidTopic( robotNamespace + "/" + _sdf->Get<std::string>("detach_topic"))); } else { detachTopics.push_back("/model/" + this->model.Name(_ecm) + "/detachable_joint/detach"); }
same for attach and state
The text was updated successfully, but these errors were encountered:
Distantly related: #1097
We should probably refactor this plugin a bit.
Sorry, something went wrong.
arjo129
No branches or pull requests
Problem description
Spawning multiple models with DetachableJoint plugin will result in only one shared detach topic.
Consider using robotNamespace like here:
gz-sim/src/systems/multicopter_motor_model/MulticopterMotorModel.cc
Line 376 in 6af7445
for all plugins.
Implementation suggestion
gz-sim/src/systems/detachable_joint/DetachableJoint.cc
Line 98 in 6af7445
same for attach and state
The text was updated successfully, but these errors were encountered: