Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍🌾 sim6 windows CI: 13 warnings #2384

Open
Crola1702 opened this issue Apr 25, 2024 · 1 comment
Open

🧑‍🌾 sim6 windows CI: 13 warnings #2384

Crola1702 opened this issue Apr 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Crola1702
Copy link
Contributor

Environment

  • OS Version: Windows
  • Source gz-sim6 build

Description

There are 13 warnings in gz_sim-ign-gazebo6-win

Steps to reproduce

  1. Run a build in gz_sim-ign-gazebo6-win
  2. See warnings appear

Output

Reference build: https://build.osrfoundation.org/job/gz_sim-ign-gazebo6-win/42/

Warnings (See attached hyperlinks for more details):

  • 9 C4273: inconsistent dll linkage
  • 1 C4834: discarding return value of function with 'nodiscard' attribute
  • 3 C4584: 'ignition::physics::detail::ComposePlugin::type': base-class 'ignition::physics::detail::ComposePlugin::n,void>' is already a base-class of 'ignition::physics::detail::ComposePlugin::type'
@Blast545
Copy link
Contributor

Blast545 commented Jun 3, 2024

🧑‍🌾 I think this could be solved by a combination of #1911 and #2254 being backported to sim6.

@mjcarroll Can I ask you to take this one? I saw you opened the two mentioned PRs, so you may have more context if anything goes wrong with those. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants