Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between custom sensor system example and internal sensor systems #2361

Open
5p00kk opened this issue Apr 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@5p00kk
Copy link

5p00kk commented Apr 5, 2024

Description

Hi, I have noticed that the implementation of the example custom sensor system (https://github.com/gazebosim/gz-sim/blob/gz-sim8/examples/plugin/custom_sensor_system/OdometerSystem.cc) diverges from the implementation used internally in gazebo (https://github.com/gazebosim/gz-sim/blob/gz-sim8/src/systems/altimeter/Altimeter.cc).

In the example, new sensors are created during PreUpdate (together with the SensorTopic component) and then updated with environmental data during PostUpdate.

In internal systems, sensors are partially created during PostUpdate and then during next PreUpdate all new sensors have SensorTopic component added.

I'm not sure if this is intentional but in my opinion should be either aligned or explained somewhere as it seems quite confusing to determine the correct way.

@5p00kk 5p00kk added the bug Something isn't working label Apr 5, 2024
@azeey azeey self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants