Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mix: Don't depend on eqc_ex in production builds #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

olof
Copy link

@olof olof commented Mar 23, 2020

Fixes #7

Edit: I've also decided to add another change to this pull request to avoid merge conflicts:

Bumping the dependency for eqc to 1.3.1. I think syntax errors in the mix.exs file causes mix to not register the eqc subcommands (they don't appear in mix help, etc). I hope I managed to bump the version reasonably, both in mix.exs and in the lock.file, but please verify that it works for you as well. You will end up with 1.3.2, but only becuase that's the most recent version compatible with ~> 1.3.1.

1.3.0 contained errors in their mix.exs, which results in no eqc
subcommands being available through mix. These issues were solved in
1.3.1.

Reference: Quviq/eqc_ex@cd37425
@olof
Copy link
Author

olof commented Mar 23, 2020

Also note: the latest eqc_ex version is 1.4.2; that works to. I've managed to run the tests with both eqc_ex 1.3.2 and 1.4.2. Should I bump it to ~> 1.4.0 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is :eqc_ex a prod dependency?
1 participant