Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is :eqc_ex a prod dependency? #7

Open
NobbZ opened this issue Sep 21, 2018 · 1 comment · May be fixed by #9
Open

is :eqc_ex a prod dependency? #7

NobbZ opened this issue Sep 21, 2018 · 1 comment · May be fixed by #9

Comments

@NobbZ
Copy link

NobbZ commented Sep 21, 2018

see subject
@gausby
Copy link
Owner

gausby commented Sep 21, 2018

It is not, and it shouldn't be. I had the same issue in another project of mine called Tortoise. It is really a matter of adding only: :test to the :eqc_ex-dependency declaration; and one might have to write MIX_ENV=test mix eqc.install --mini when setting up the development environment.

You can make a pull request if you want to…otherwise I will do it when I get to it :)

olof added a commit to olof/elixir-bencode that referenced this issue Sep 9, 2019
@olof
mix: Make eqc dependeny is test specific
26b909e 
Fixes gausby#7
olof added a commit to olof/elixir-bencode that referenced this issue Mar 23, 2020
@olof
mix: Don't depend on eqc_ex in production builds
5e9c9a9 
Fixes gausby#7
@olof olof linked a pull request Mar 23, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mix: Don't depend on eqc_ex in production builds olof/elixir-bencode
2 participants
@NobbZ @gausby