[GEP-19] Adapt monitoring configuration for shoot cluster system components #9737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/monitoring
46 tasks
gardener-prow
bot
added
the
size/XXL
rfranzke
force-pushed
the
gep19/in-tree-cluster
branch
from
40bbe80
to
2084d04
Compare
|
/assign |
ScheererJ
reviewed
May 22, 2024
pkg/component/observability/monitoring/prometheus/shoot/utils.go
Outdated
Show resolved
Hide resolved
pkg/component/observability/monitoring/prometheus/shoot/utils.go
Outdated
Show resolved
Hide resolved
pkg/component/observability/monitoring/nodeexporter/nodeexporter.go
Outdated
Show resolved
Hide resolved
pkg/component/observability/monitoring/nodeexporter/nodeexporter.go
Outdated
Show resolved
Hide resolved
pkg/component/observability/monitoring/nodeexporter/nodeexporter.go
Outdated
Show resolved
Hide resolved
…s running inside the shoot cluster
rfranzke
force-pushed
the
gep19/in-tree-cluster
branch
from
2084d04
to
6fe62de
Compare
|
LGTM label has been added. Git tree hash: 41b5f5efc4dfcbb38a18402c2576a7e50cfe0771
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 24, 2024
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
As a follow-up of #9695, this PR adapts the monitoring configuration for the system components running inside the shoot cluster.
The shoot cluster control plane components will be adapted in a subsequent PR.
Which issue(s) this PR fixes:
Part of #9065
Special notes for your reviewer:
/cc @ScheererJ
Release note:
Extensions deploying shoot cluster system components can now make use of the `pkg/component/observability/monitoring/prometheus/shoot.ClusterComponentScrapeConfigSpec` function in order to generate a [`ScrapeConfig`](https://github.com/gardener/gardener/blob/master/docs/extensions/logging-and-monitoring.md#scrapeconfigs) for the shoot's Prometheus.