[GEP-26] Move CredentialsBinding to security.gardener.cloud group #9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
cla: yes
|
/assign |
vpnachev
changed the title
|
/assign |
ialidzhikov
requested changes
May 13, 2024
...r/controlplane/charts/application/templates/apiservice-v1alpha1-security-gardener-cloud.yaml
Show resolved
Hide resolved
ialidzhikov
requested changes
May 13, 2024
...r/controlplane/charts/application/templates/apiservice-v1alpha1-security-gardener-cloud.yaml
Show resolved
Hide resolved
ialidzhikov
reviewed
May 13, 2024
...r/controlplane/charts/application/templates/apiservice-v1alpha1-security-gardener-cloud.yaml
Show resolved
Hide resolved
ialidzhikov
requested changes
May 13, 2024
|
LGTM label has been added. Git tree hash: 9bb30620202ac64d78f20d89ef983358cb94bd95
|
gardener-prow
bot
added
the
approved
|
LGTM label has been added. Git tree hash: 65f569586982a190cd51f41f8eabd9087dc8cb1b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
rfranzke
pushed a commit
to metal-stack/gardener
that referenced
this pull request
May 14, 2024
…rdener#9734) * Move CredentialsBinding to security.gardener.cloud group * Address review feedback * Fix reference to security api docs * Fix the integration test --------- Co-authored-by: ialidzhikov <i.alidjikov@gmail.com>
|
/area ipcei |
gardener-prow
bot
added
the
area/ipcei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind bug
What this PR does / why we need it:
Move CredentialsBinding to
security.gardener.cloudgroup becauseauthentication.gardener.cloud/v1alpha1is already used by OWA https://github.com/gardener/oidc-webhook-authenticator/blob/d272537756d0e600e904dd98062ca244d18ea982/apis/authentication/v1alpha1/groupversion_info.go#L17.Which issue(s) this PR fixes:
Part of #9586
Follow up on #9626
Special notes for your reviewer:
Release note: