Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnt-network mode ext #41

Open
wants to merge 4 commits into
base: stable-2.16
Choose a base branch
from
Open

Conversation

atta
Copy link
Contributor

@atta atta commented Apr 27, 2017

this patch allow the user to use the mode=ext within ganeti.
So if a vm is starting, the script "/usr/share/ganeti/extnetwork//up" given by the gnt-network-tag "ext_provider" is triggerd.

We use this to create a vxlan on the node wehn ever it is needed, but a lot of other things are imaginationable.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@atta
Copy link
Contributor Author

atta commented Apr 27, 2017

i have signed the CLA some time ago but it did not show up
Google Individual CLA Ansgar Jazdzewski Dec 03, 2012 21:57 PST

@Morgawr Morgawr mentioned this pull request May 11, 2017
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 3, 2017
@Morgawr
Copy link
Collaborator

Morgawr commented Jul 10, 2017

Should I be closing this as duplicate of #42 or are you still working on this? If you're planning to submit a future PR with everything implemented, I'll take a look at that and close this one as duplicate of #42, otherwise I can independently review and merge this while waiting for the next one.

@iustin
Copy link
Contributor

iustin commented Mar 5, 2018

Ping, what's the status on this? And repeating the question on the disk io patch, should this rather be against master?

@atta
Copy link
Contributor Author

atta commented Feb 23, 2019

hi can we bing this back up for ganeti 3.0? i will update the PR

@apoikos
Copy link
Member

apoikos commented Feb 23, 2019

@atta, sure!

@atta atta added the Ganeti 3.1 Patches for Ganeti 3.1 label Sep 4, 2020
@atta atta added this to the Release 3.1 milestone Sep 4, 2020
@rbott
Copy link
Member

rbott commented Sep 23, 2021

@atta could you try to re-implement this against the current master?

Also it needs documentation (it should be mentioned as an option in the instance parameter list but I think it also deserves some example code. Currently there is some network-related content in the installation tutorial. Maybe we should in general cover all network modes in the administrator's guide, but that is for another PR to address :-)

Update: it also needs to be covered in the up/downgrade code. In this case probably only the downgrade scenario is relevant, removing the then-illegal values from the config database.

@rbott rbott removed the cla: yes label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ganeti 3.1 Patches for Ganeti 3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants