Make RBD user-id configurable #1680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This picks up where PR ganeti#1515 left and adds the missing bits. Most of the work has been done by @oleeander. The user id is used by ceph to determine the keyring to use for authentication. By default the admin keyring is used, which may not be desirable. Example usage: $ gnt-cluster modify -D rbd:user-id=foobar Signed-off-by: Rudolph Bott <r@spam.wtf> Co-authored-by: Oleander <oleander@oleander.cc>
|
This PR still needs some finalization. Feel free to review, but I need to test/verify the upgrade/downgrade part. This might be nonsense right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up where PR #1515 left and adds the missing bits. Most of the work has been done by @oleeander.
The user id is used by ceph to determine the keyring to use for
authentication. By default the admin keyring is used, which may
not be desirable. Example usage:
$ gnt-cluster modify -D rbd:user-id=foobar