Pass events.time_ref to observation.pointing.to_fits_headerin observation.write
#5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it also need a backport in 1.1.x . |
registerrier
approved these changes
May 9, 2024
There was a problem hiding this comment.
Thanks @MRegeard . This looks good. Is the bug affecting v1.0.2? Does this need backporting to v1.0.x too?
v1.1.x is no longer maintained. No backport there.
|
@registerrier, Looking at the code in v1.0.x, I don't think it affect it because pointing is not used: gammapy/gammapy/data/observations.py Lines 494 to 496 in 547b342 |
bkhelifi
approved these changes
May 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/gammapy
that referenced
this pull request
May 16, 2024
…ting.to_fits_header`in `observation.write`
registerrier
added a commit
that referenced
this pull request
May 16, 2024
…7-on-v1.2.x Backport PR #5257 on branch v1.2.x (Pass `events.time_ref` to `observation.pointing.to_fits_header`in `observation.write`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #5256.
I pass the time reference of the eventlist to
pointing.to_fits_headerinobservation.writeso that the MJDREFF and MJDREFI written in the header of the eventlist is not set to 0 but to the good value.