Make non-FITS table file from FluxPoints overwritable

[HealthyPear]

Description

See #5253.

Propagated astropy.table.Table.write() overwrite to FluxPoints.write() when file extension is not .fits.

This pull request closes #5253.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (50bbef6) to head (a048535).
Report is 43 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5254       +/-   ##
===========================================
+ Coverage   75.26%   94.25%   +18.99%     
===========================================
  Files         234      234               
  Lines       35131    35226       +95     
===========================================
+ Hits        26442    33204     +6762     
+ Misses       8689     2022     -6667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[registerrier]

Thanks @HealthyPear . This looks good. Could you maybe check why the test is not failing with the current version?

[HealthyPear]

Sure. Could you point me to the test function? I am not familiar with the test suite of this project.

[registerrier]

Sure. Could you point me to the test function? I am not familiar with the test suite of this project.

Here it is:

gammapy/gammapy/estimators/points/tests/test_core.py

Line 213 in 2475a00

def test_write_ecsv(self, tmp_path, flux_points):

[HealthyPear]

I think the problem is that you are writing that file in the tmp_path, but you never stored it there before, you load it from "$GAMMAPY_DATA/tests/spectrum/flux_points/, which is not the same path, so there is not overwriting in the first place.

We should either copy the original file in tmp_path (or maybe even touch a dummy one) and only then attempt to write the table file.

[registerrier]

We should either copy the original file in tmp_path (or maybe even touch a dummy one) and only then attempt to write the table file.

touching a dummy file with the same name sounds good to me.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v1.0.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 b8282337f83e61da71836c2c3d6f77fdf24d6dde

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #5254: Make non-FITS table file from FluxPoints overwritable'

4. Push to a named branch:

git push YOURFORK v1.0.x:auto-backport-of-pr-5254-on-v1.0.x

5. Create a PR against branch v1.0.x, I would have named this PR:

"Backport PR #5254 on branch v1.0.x (Make non-FITS table file from FluxPoints overwritable)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[registerrier]

This cannot be backported to v1.0.x because export to non-FITS file was not available in v1.0.

gammapy/gammapy/estimators/points/core.py

Lines 174 to 179 in 547b342

	if sed_type is None:
	sed_type = self.sed_type_init
	filename = make_path(filename)
	table = self.to_table(sed_type=sed_type, format=format)
	table.write(filename, **kwargs)