Compile against numpy 2.0 when building wheels, define target api version #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5216 +/- ##
===========================================
+ Coverage 75.12% 94.25% +19.13%
===========================================
Files 234 234
Lines 34941 35224 +283
===========================================
+ Hits 26248 33202 +6954
+ Misses 8693 2022 -6671 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
|
The devdeps tests now run locally once removing the astropy and numpy constraints. There are numerous errors appearing. Most of them are due to the change in |
registerrier
approved these changes
May 16, 2024
There was a problem hiding this comment.
Thanks @maxnoe . The devdeps tests are now properly run. I propose to solve the fails in a subsequent PR.
registerrier
added a commit
to registerrier/gammapy
that referenced
this pull request
May 16, 2024
Compile against numpy 2.0 when building wheels, define target api version
registerrier
added a commit
that referenced
this pull request
May 16, 2024
Backport #5216: Compile against numpy 2.0 when building wheels, define target api version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to provide wheels that are compatible with both numpy 2.0 and 1.x.
Building will happen always against the newest version of numpy and wheels will be ABI compatible with numpy >=
NPY_TARGET_VERSIONDescription
This pull request ...
Dear reviewer