Adjust to_edisp_kernel input to MapAxis

[Astro-Kirsty]

This PR is to resolve #5142.
I left it as a draft as I am not sure if this is the correct procedure to take.
This is two part issue, we want to change the variables to be consistent with the other naming for axis

gammapy/gammapy/irf/edisp/map.py

Line 116 in 86488ec

def to_edisp_kernel_map(self, energy_axis):

We also need to change the variable to no longer be a quantity but a MapAxis.

This was the best way I could think to achieve this.

Note: there are a number of failing tests, but I did not want to fix them all with the deprecation warning until a method was decided upon.

I am open to suggestions.

[AtreyeeS]

Thanks @Astro-Kirsty !

I do not think you need to adapt internet tests to check for the deprecation warning, eg as done in gammapy/datasets/tests/test_map.py
It only needs to be checked when the user passes a quantity instead of a MapAxis in the to_edisp_kernel function, and internally within Gammapy we should pass a MapAxis.

[AtreyeeS]

Do you want to rename the argument name or keep the name and change the type?
Either of the two should suffice, no?

If a DepricationWarning is raised about the argument name, then the warning below is not necessary.

I think we can keep the argument same same, and just allow a MapAxis on input. Then, we can raise a deprecation warning if a Quantity is passed

[Astro-Kirsty]

I changed the argument name to be consistent with others in the code, for example here.

[AtreyeeS]

I don't have a strong opinion here - you can modify the name and remove the warning about passing the Quantity.
You will anyways need to adapt all calls to to_edisp_kernel to take a MapAxis now.

[Astro-Kirsty]

Okay sure thing! Will do

[Astro-Kirsty]

So deprecated_renamed_argument will only let the user know that there was a name change, but not that it should now be a MapAxis

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.28%. Comparing base (637570a) to head (36ae743).
Report is 5 commits behind head on main.

Files	Patch %	Lines
gammapy/irf/edisp/tests/test_core.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5186   +/-   ##
=======================================
  Coverage   75.27%   75.28%           
=======================================
  Files         234      234           
  Lines       35148    35150    +2     
=======================================
+ Hits        26458    26461    +3     
+ Misses       8690     8689    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.