3PC Fermi catalog #5058
Merged
3PC Fermi catalog #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRegeard
force-pushed
the
3PC_fermi_catalog
branch
from
a6d3fbf
to
0d73038
Compare
MRegeard
force-pushed
the
3PC_fermi_catalog
branch
from
8c95ca8
to
06efcef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5058 +/- ##
==========================================
- Coverage 75.27% 75.07% -0.20%
==========================================
Files 234 234
Lines 35148 35270 +122
==========================================
+ Hits 26458 26480 +22
- Misses 8690 8790 +100 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
MRegeard
force-pushed
the
3PC_fermi_catalog
branch
from
d9a1b2b
to
3c2fea9
Compare
registerrier
reviewed
May 7, 2024
There was a problem hiding this comment.
Thanks @MRegeard . This looks good.
See some inline comments.
gammapy/catalog/tests/test_fermi.py
Outdated
| def test_data(self): | ||
| assert_allclose(self.source.data["P0"], 0.08937108859019084) | ||
|
|
||
| @pytest.mark.parametrize("ref", SOURCES_3PC, ids=lambda _: _["name"]) |
There was a problem hiding this comment.
Why is the ids argument used for?
There was a problem hiding this comment.
I actually don't know, I follow the same testing scheme as for the other catalogs. Maybe @QRemy knows ?
There was a problem hiding this comment.
I think it loops over the sources in the list.
registerrier
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting merge of #5056.
Split of PR #4699. Here is the 3PC part.