2PC Fermi catalog #5057
Open
2PC Fermi catalog #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
Signed-off-by: Maxime Regeard <regeard@apc.in2p3.fr>
MRegeard
force-pushed
the
2PC_fermi_catalog
branch
from
bca8835
to
36cb4e1
Compare
|
Could you rebase @MRegeard ? |
|
Can you rebase and update now that 3PC has been merged @MRegeard ? |
|
@registerrier, it's done. I have to check that everything is fine because the rebase was a mess ! |
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
QRemy
reviewed
May 17, 2024
QRemy
reviewed
May 17, 2024
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de> add minimal docstring for 3PC Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
Signed-off-by: Quentin Remy <quentin.remy@mpi-hd.mpg.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5057 +/- ##
==========================================
- Coverage 94.47% 94.47% -0.01%
==========================================
Files 235 235
Lines 35566 35699 +133
==========================================
+ Hits 33600 33725 +125
- Misses 1966 1974 +8 ☔ View full report in Codecov by Sentry. |
merge main to this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting merge of #5056.
Split of PR #4699. Here is the 2PC part.