Addition of an ExtensionEstimator #4419
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Régis Terrier <rterrier@apc.in2p3.fr>
registerrier
changed the title
adonath
reviewed
Mar 24, 2023
| # find extension parameter | ||
| model = datasets.models[self.source].spatial_model | ||
|
|
||
| if hasattr(model, "sigma"): |
There was a problem hiding this comment.
I think this code block should go into the estimate_size() function instead and use the size parameter just as local variable.
|
Thanks @registerrier, this is very interesting and covers an important use case. As this is still a draft I just have a few preliminary comments:
|
|
@registerrier, should you update your branch such that the tests pass? |
bkhelifi
reviewed
Sep 15, 2023
| Edges of the energy intervals where the extension is estimated. | ||
| source : str or int | ||
| For which source in the model to compute the extension. | ||
| size_min : float |
There was a problem hiding this comment.
Maybe the default values should be added in the docstring...
bkhelifi
reviewed
Sep 15, 2023
|
|
||
| def __init__( | ||
| self, | ||
| energy_edges=[1, 10] * u.TeV, |
There was a problem hiding this comment.
Maybe these default values should be removed... to be generic and to force the user to add edges
bkhelifi
reviewed
Sep 15, 2023
|
@registerrier can you update your code from the main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request proposes an
ExtensionEstimatorbased on the parameter estimator.A possible improvement compared to the typical functionalities of the
ParameterEstimatorwould be to handle a case where the extension parameter is kept fixed between all energies and then released to test the energy dependent morphology.Dear reviewer