New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass events.time_ref
to observation.pointing.to_fits_header
in observation.write
#5257
Conversation
I think it also need a backport in 1.1.x . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MRegeard . This looks good. Is the bug affecting v1.0.2? Does this need backporting to v1.0.x too?
v1.1.x is no longer maintained. No backport there.
@registerrier, Looking at the code in v1.0.x, I don't think it affect it because pointing is not used: gammapy/gammapy/data/observations.py Lines 494 to 496 in 547b342
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @MRegeard
…ting.to_fits_header`in `observation.write`
…7-on-v1.2.x Backport PR #5257 on branch v1.2.x (Pass `events.time_ref` to `observation.pointing.to_fits_header`in `observation.write`)
This PR fix #5256.
I pass the time reference of the eventlist to
pointing.to_fits_header
inobservation.write
so that the MJDREFF and MJDREFI written in the header of the eventlist is not set to 0 but to the good value.