Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect the MapAxis directly in to_edisp_kernel #5142

Open
Astro-Kirsty opened this issue Mar 4, 2024 · 0 comments · May be fixed by #5186
Open

Expect the MapAxis directly in to_edisp_kernel #5142

Astro-Kirsty opened this issue Mar 4, 2024 · 0 comments · May be fixed by #5186
Assignees
@Astro-Kirsty
Labels
cleanup question
Milestone
1.3

Comments

@Astro-Kirsty
Copy link
Member

Astro-Kirsty commented Mar 4, 2024 •
edited

Should we expect directly the MapAxis here? (Note: this is a TODO converted into an issue)

gammapy/gammapy/irf/edisp/core.py

Lines 145 to 148 in e5aecb3

if energy is None:
energy_axis = self.axes["energy_true"].copy(name="energy")
else:
energy_axis = MapAxis.from_energy_edges(energy)

Solution
'energy' should be a MapAxis type. This needs a small API changes and deprecations so that 'energy' is a MapAxis and not a Quantity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Astro-Kirsty Astro-Kirsty

Labels
cleanup question
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Adjust to_edisp_kernel input to MapAxis Astro-Kirsty/gammapy
2 participants
@registerrier @Astro-Kirsty