feat: Added functions to configure ca certificate to the global-agent #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instance. Also added setter method to add ca after instance is created
Updated readme file
Added ca parameter's type
fixed formatting issue
Updated test
updated test
Updated test
Signed-off-by: VKMEHRA <VKMEHRA@VKMEHRA-PH1.idc.oracle.com>
As boolean() method is not present so removed it and updated getRejectUnauthorized method
updated method getRejectUnauthorized
Updated type of ca to either string | string[] | undefined
Removed default value [] for ca
updated ca type to be either string | string[] | undefined
Updated ca to be either string | string[] | undefined
Updated methods addCACertificates and clearCACertificates
|
@gajus These are final changes, please review them and let me know if your feedback |
|
@gajus did you get a chance to code review changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided options to configure ca certificate to the global-agent
Please review the code.