Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to stage an update and then commit it at a later point in time.
You call the existing
Update
endpoint with a new flag, this should be backwards compatible because the flag will default tofalse
, and then instead of writing toobjects
the rows will be written todl.staged_objects
.You can then follow up with a call to a new RPC endpoint
Commit
which will actually make that version the current version for your project.The main, fairly conservative, decision that I took was to only allow you to commit a version if no updates have happened since you staged it.
This means if you:
I think this makes it much easier to reason about, but it could be problematic in practice where multiple systems are trying to update a project at once.
Remaining TODOs:
Add testsEnsure that the GC can't delete objects that are currently staged