Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sonar.host.url (not sonar.core.serverBaseURL) for calling webservices #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomasgl-orange
Copy link

In our company, the network environment is such that the public URL of SonarQube servers (defined by the sonar.core.serverBaseURL property in the server config) is not the same as the internal URL which can be reached from the Gitlab-CI runners. This is usually not an issue at all for running SQ analysis (what matters is the sonar.host.url property set for the SonarQube Scanner, and all webservices are called from the Gitlab-CI runners with his URL, not the public one). But with the sonar-gitlab-plugin, it became an issue, because this plugin tries to use the public URL to call a webservice (to retrieve the Quality Gate status at the end of the analysis).

This patch tries to fix that: it introduces a distinction between GitLabPluginConfiguration.baseUrl (the public URL, to be used for user-facing links to SonarQube web pages) and GitLabPluginConfiguration.baseWsUrl (which is basically sonar.host.url or the localhost:9000 default, thus whatever URL has actually been used for running this SonarQube analysis). The later is used in the SonarFacade only, and the former is still used everywhere else.

@thomasgl-orange
Copy link
Author

FYI, this PR is not exactly what we're using to workaround this issue, because our SonarQube server are still in version 6.7 LTS. Here is a similar patch for version 3.0.2 of the sonar-gitlab-plugin:
thomasgl-orange/sonar-gitlab-plugin@1d6700c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant