This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Make referencesets optional when possible #1596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david4096
commented
Mar 2, 2017
| @@ -221,9 +221,13 @@ def printSummary(self): | |||
| sep="\t") | |||
| print("\tVariantSets:") | |||
| for variantSet in dataset.getVariantSets(): | |||
| referenceSetName = "" | |||
There was a problem hiding this comment.
These should be refactored into one method, safeGetReferenceSetName.
david4096
force-pushed
the
1528_referencesets_optional
branch
from
578a2d7
to
a8814a5
Compare
Allow nullity for referencesetid field in models Safely access the referenceset name in a few places
Remove reference set from RNA (it's not in the schemas) Adding functions to safely get reference set name and ID
david4096
force-pushed
the
1528_referencesets_optional
branch
from
a8814a5
to
53319d3
Compare
david4096
commented
Mar 4, 2017
| def safeGetReferenceSetByName(self, referenceSetName): | ||
| """ | ||
| Gets a reference set by name from the repository throwing a useful | ||
| exception if it is not found. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo manager requires that a reference set is provided when it is really only a metadata item from the perspective of the variants, features, and RNA. For this reason, we can make it an optional flag at the repo manager.
I am able to add a variant set using just:
python repo_dev.py add-variantset ga4gh-example-data/registry.db brca1 ga4gh-example-data/brca1_1kgPhase3_variants.vcf.gzAllow nullity for referencesetid field in modelsSafely access the referenceset name in a few placesWe should strongly consider a PR at the schemas that removes the
referenceIdas a required field of a reads search, as that is the only endpoint that can't implement this feature.Works to close #1528, thanks @ejacox for helping us keep focus on usability features.