Send_ConfigInfo improvements #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThomasAdam
commented
Apr 28, 2024
ThomasAdam
commented
- Send_ConfigInfo: change desktop_geometry ordering
- BroadcastMonitorList: use helper function
- DesktopConfiguration: send in a separate reply
Honour the comment of the packets being sent, and move the desktop geometry information after sending ImagePath and ColorLimit.
Split out the sending of monitor information to use a helper function to reduce code duplication.
Split out the DesktopConfiguration information into its own request. Help some of the overhead by not allocating the information on the heap; send on the stack instead.
ThomasAdam
force-pushed
the
ta/send-config-info
branch
from
f9bead6
to
d000a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.