[Bug Fix+Feature] [IE10+] can't hide dropdown after using scrollbar, [Feature] inputProps #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 25, 2017 10:02
… clicking outside, replace some ref strings with ref functions
…lib to the package.json file
This was referenced Jul 23, 2017
# Conflicts: # package.json # src/DropdownMenu.ls # src/ResizableInput.ls
… into bugfix/ie10-scroll-bug # Conflicts: # README.md # package.json # public/examples/multi/DropdownDirection.ls # src/DropdownMenu.ls # src/MultiSelect.ls # src/ResizableInput.ls # src/SimpleSelect.ls # test/index.ls
elisherer
changed the title
…or of ResizableInput
|
@furqanZafar , I resolved all the conflicts with the new version, I hope you could go over this one and approve it. (I suggest squashing my commits, since I had too many mistakes during the merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on the scrollbar on IE10+ and then outside the dropdown don't hide.
There is handling for it in the code, but it doesn't work.
This can be reproduced on the demo site
Also, refs are now needs to be functions instead of strings.
source
Update forgot to mention:
I also fixed the passing of inputProps to ResizableInput (and on that go, I replaced it definition with class)