[FEATURE] Uses accept field to validate provided filetypes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return fileExtensions.some(extension => validExtensions.indexOf(extension) === -1); | ||
| }, | ||
|
|
||
| handleFiles: function(files) { | ||
| if (typeof(this.filesAreValid) === 'function') { |
There was a problem hiding this comment.
Can you move the block into a function _validate and call your function in _validate?
timmcanty
force-pushed
the
validate-with-accept-field
branch
from
3c1172a
to
c14b86d
Compare
| if (typeof(this.filesAreValid) === 'function') { | ||
| if (!this.filesAreValid(files)) { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| if (this._invalidExtension(files)) { |
There was a problem hiding this comment.
@timmcanty can you add a setting validateExtension default can be true and add it to the readme`s Options section?
|
@timmcanty i updates ember cli and fixed the tests. can you rebase against master? |
timmcanty
force-pushed
the
validate-with-accept-field
branch
from
c14b86d
to
46a69a0
Compare
|
Updated |
| @@ -25,6 +25,7 @@ export default Component.extend({ | |||
| dropzone: true, | |||
| progress: true, | |||
| showProgress: false, | |||
| validateExtension: true, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at working with #13
Would be helpful for my use case.