Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle reading error #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

isamankumara
Copy link

I have done the error handling when read. Other error also can handle using delegate method.

@fulldecent
Copy link
Owner

Thank you this is very interesting.

First could you please correct the typos.

Also, could you please reference a well respected project (like Alamofire) that uses a similar approach?

@fulldecent
Copy link
Owner

FYI, I made a note here https://github.com/fulldecent/FDWaveformView/blob/master/README.md#contributing it is not just you! Thanks for your help and understanding.

@isamankumara
Copy link
Author

I need small clarification.

  1. I am sorry I am unable to find typo. Can you help me to do that.

For the similar approach on other project.
You can find delegate methods on following url
https://github.com/Alamofire/Alamofire/blob/master/Source/SessionDelegate.swift

We need to add fail delegate method for the library. Because on current app it will be go to the dead end. (since it not handling) . I have handle when music file not loading properly .
But there are so many reason to load FDWareform, so we wanted to add any other also. That's why I adding enum.

@fulldecent
Copy link
Owner

We just merged #80. Sorry, this messes up your commit. Could you please take a look at the new API and rebase to that?

Sorry, I cannot find this "typo", please ignore about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants