Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out data source #144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Factor out data source #144

wants to merge 4 commits into from

Conversation

fulldecent
Copy link
Owner

@fulldecent fulldecent commented Dec 27, 2020

Progress:

  • Create DataSource protocol which could be applicable to audio files or any other data source, such as an array or other generator
  • Move all existing audio code into an implementation of this DataSource
  • Use [Float] as the type for the DataSource

This is nearly done. Please help with the last item if you'd like to get a couple commits in.

@fulldecent
Copy link
Owner Author

There is a currently a Swift Evolution that is related here

https://github.com/apple/swift-evolution/blob/main/proposals/0307-allow-interchangeable-use-of-double-cgfloat-types.md

and it might impact the choice of Float above

@fulldecent
Copy link
Owner Author

We can use Double now because the proposal above was implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant