Fixed Runtime.js to not always remove last argument #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where if you used any Async method in a standard await function, it would always remove the last argument of the function you are trying to call (if you supplied any) Which isn't supposed to happen. This doesn't happen if you use the default Async method, via the water-fall method, where the function you are trying to call is embedded to the call itself. Now supports both methods! 1. Water-fall (call-back embedded) 2. Standard await.
Run with "node fix1.js"
There was a bug that didn't allow you to run execute multiple times, especially after something like a delay. A flag was being reset. Being able to run .execute multiple times is part of the charm. Includes a test. Run with "node fix2.js"
|
Also fixed sandbox.js Includes a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where if you used any Async method in a standard await function, it would always remove the last argument of the function you are trying to call (if you supplied any)
Which isn't supposed to happen.
This doesn't happen if you use the default Async method, via the water-fall method, where the function you are trying to call is embedded to the call itself.
Now supports both methods!
See the included test for an example. It crashes on the current Runtime.js.
But fixed on the pull request.