Force cryptography<2.1 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #175 |
|
Fixes #175 |
In version 2.1 of cryptography, support for RIPEMD160 hashes got removed. Credstash still points to those; I chose to modify setup.py rather than remove that hash family from credstash, as that would probably have more downstream consequences
|
Well done @afallou! LGTM |
|
This change fixed it for me as well. Thank you! |
|
I think the proper solution would be: #176 |
mfisher29
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.1 of cryptography, support for RIPEMD160 hashes got removed (see cryptography
mastervs2.0.x), but Credstash still points to those.I chose to modify setup.py rather than remove that hash family from credstash, as that would probably be disruptive for other users of
credstash.