Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.1.2, PHPUnit 10.2.5] Make phpunit executable #2193

Open
wants to merge 1 commit into
base: 1.9/develop
Choose a base branch
from

Conversation

Nao000
Copy link

@Nao000 Nao000 commented Jul 15, 2023

I encountered an issue while running PHPUnit in PHP 8.1.2 and PHPUnit 10.2.5 environment.

The problem arises due to the following reasons:

  • Incompatibility of return types in some methods.
  • Fuel\Core\Arraylike::getIterator() doesn't conform to IteratorAggregate::getIterator(): Traversable compatibility or the use of #[\ReturnTypeWillChange] is missing.

Although the tests fail, this pull request enables the execution of PHPUnit.

Signed-off-by: nao000 <nao000dotcom@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant