Add multiple cookies #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ability to add multiple cookies in a single step, from a list of cookie strings
SchlenkR
reviewed
Jan 29, 2022
There was a problem hiding this comment.
- In general, the functions in
DslCEare basically mirrored from the functions inDsl. The implementation is inDslmodule and theDslCEfunctions are forwarding calls to their correspondingDslfunction. - What is the benefit of a single
Cookiesoperation passing a seq of cookies in comparison to use multiple single-Cookiestatements? I don't see a big advantage here - maybe a little less writing - but some downsides:- There are 3 overloads for single cookies that clarify the available parameters and their meaning. Having just one
Cookiesoperation that gets a sequence of strings will hide that. - Writing multiple single-cookie statements are close to how a raw HTTP request looks like.
- There are 3 overloads for single cookies that clarify the available parameters and their meaning. Having just one
|
Related to #2 |
|
yes i agree, maybe is not needed but indeed was linked to trying to read Accept-Cookies from response headers and place them all in the new request in 1 go |
The response header I know is If so, it would propable be useful to change the signature to accepting either
Do you have a working example (maybe with an available online test service)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ability to add multiple cookies in a single step, from a list of cookie strings