Honor ListObjects IncludeTrailingDelimiter #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
reviewed
Feb 12, 2022
gaul
added a commit
to gaul/google-cloud-go
that referenced
this pull request
Feb 12, 2022
gaul
added a commit
to gaul/google-cloud-go
that referenced
this pull request
Feb 12, 2022
gaul
force-pushed
the
include-trailing-delimiter
branch
from
b62998e
to
b973949
Compare
Done but blocked on googleapis/google-cloud-go#5617. |
gaul
added a commit
to gaul/google-cloud-go
that referenced
this pull request
Feb 26, 2022
gaul
added a commit
to gaul/google-cloud-go
that referenced
this pull request
Mar 1, 2022
tritone
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Mar 1, 2022
References fsouza/fake-gcs-server#676. Co-authored-by: Chris Cotter <cjcotter@google.com>
This allows gcsfuse to list directory objects which end with / and allows pjdfstest rmdir/06.t to pass. References GoogleCloudPlatform/gcsfuse#590.
We can go back to the release version once googleapis/google-cloud-go#5693 is merged.
fsouza
force-pushed
the
include-trailing-delimiter
branch
from
a2497d4
to
9e1ba27
Compare
fsouza
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows gcsfuse to list directory objects which end with / and
allows pjdfstest rmdir/06.t to pass. References
GoogleCloudPlatform/gcsfuse#590.