WIP: read config from environment variables #1608
Open
+80
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vichle
changed the title
|
@fsouza some feedback would be appreciated :) |
Sorry I completely missed this, will take a look later today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of reading configuration from environment variables (#561) . I chose a different approach than #1041, let me know what you think! I've only added support for a single arg for now:
backendusing theFAKE_GCS_BACKENDenvironment variable. I'll update the PR with the rest of the arguments if you think this is a good way of doing it.I don't usually write golang, so please be thorough in your feedback :)
Open questions: