Added support to detect when /tmp is mounted noexec #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleavr
requested changes
Dec 7, 2022
src/linux/system-linux.c
Outdated
| * In Linux 2.6 rootfs mount always exists, and it makes sense to always | ||
| * ignore it. | ||
| */ | ||
| if (g_strcmp0(current->mnt_fsname, "rootfs") == 0) |
There was a problem hiding this comment.
(Here and elsewhere.) Can current->mnt_fsname be NULL? If not, we should be using strcmp().
There was a problem hiding this comment.
The man page for getmntent_r doesn't explicitly say that the structure member can be NULL, or that it can't. Given we may find ourselves running on many different versions of libc and perhaps different variants too (e.g. uClibc, musl) is it prudent to be safe?
WorksButNotTested
force-pushed
the
noexec
branch
2 times, most recently
from
1aa9e88
to
94fc0ea
Compare
WorksButNotTested
force-pushed
the
noexec
branch
from
94fc0ea
to
617785e
Compare
WorksButNotTested
force-pushed
the
noexec
branch
3 times, most recently
from
73ecc4a
to
7fd7070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.