iPad sheet presentation height constraint #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unopened state:
Opened before change:
Opened after change:
|
BalazsSzamody
force-pushed
the
fix/keyboard-height-ipad-sheet
branch
from
53cd5c1
to
227ce4f
Compare
StewThom
approved these changes
Apr 22, 2022
BalazsSzamody
force-pushed
the
fix/keyboard-height-ipad-sheet
branch
from
227ce4f
to
4fd8550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
The height constraint adjustment didn't count with the possibility of the
owningViewnot reaching the bottom of the window, so theKeyboardLayoutGuidewas higher than it should have been.(iPad sheet presentation)