Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreshPorts report #345

Closed
wants to merge 7 commits into from
Closed

Add FreshPorts report #345

wants to merge 7 commits into from

Conversation

dlangille
Copy link
Contributor

No description provided.

Copy link
Contributor

@pauamma pauamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once these typos are fixed. (Fixable on commit.)

@dlangille
Copy link
Contributor Author

Good changes, thanks.

dlangille and others added 4 commits March 2, 2024 07:30
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
@dlangille
Copy link
Contributor Author

Have I done all the things to bring in all the things?

@grahamperrin
Copy link
Contributor

Have I done all the things to bring in all the things?

I guess so, thanks, however it's not for me to approve.


Note to self: the suggested changes feature brings simplicity, however in a case such as this – where I use the feature to suggest changes that originated from someone else – the commits do not show the other person's name. Sorry @pauamma

Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small more changes and this is ready for commit. Feel free to commit it yourself or I can commit it for you if you prefer.

Thanks for your report.

dlangille and others added 2 commits March 8, 2024 12:17
Co-authored-by: Lorenzo Salvadore <developer@lorenzosalvadore.it>
Co-authored-by: Lorenzo Salvadore <developer@lorenzosalvadore.it>
@dlangille
Copy link
Contributor Author

I hope I've covered all pending changes.

freebsd-git pushed a commit that referenced this pull request Mar 20, 2024
Reviewed by:	status (Pau Amma <pauamma@gundo.com>),
		Graham Perrin <grahamperrin@gmail.com>
Pull Request:	#345
@lsalvadore
Copy link
Member

Merged, thanks.

@lsalvadore lsalvadore closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants