Skip to content
This repository has been archived by the owner on Apr 1, 2021. It is now read-only.

Linters #1054

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Linters #1054

merged 1 commit into from
Jun 2, 2016

Conversation

tanham
Copy link
Contributor

@tanham tanham commented May 28, 2016

Closes #608

@ghost ghost self-assigned this May 28, 2016
@@ -0,0 +1,9 @@
Linting is the process of running a program that analyzes your code for programmatic and stylistc errors. A linting tool or a linter marks or flags any potential errors in your code such as syntax errors or incorrectly spelled variable names. This can save time and help you write better code.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylistc stylistic

tool or a linter marks tool, or a linter, marks

@tanham
Copy link
Contributor Author

tanham commented May 28, 2016

hey it's my first time contributing. Should I add the changes in another commit or is there some other way of doing it?

@ghost
Copy link

ghost commented May 28, 2016

@tanham21 Yeah, just make a new commit on your PR branch!

@tanham
Copy link
Contributor Author

tanham commented May 28, 2016

I attempted to squash my commits via command line. Sorry if I didn't follow proper protocol. I will next time.

@ghost
Copy link

ghost commented May 28, 2016

@tanham21 Push your updated commits using git push -f origin linters

@tanham
Copy link
Contributor Author

tanham commented May 28, 2016

Okay. I did that. Did it work?

@Rafase282
Copy link
Member

It didn't work, try again but make sure to do d for drop on the commit at the bottom which should be the one you didnt edit.

@tanham
Copy link
Contributor Author

tanham commented May 29, 2016

I tried again with no luck. My branch 'linters' is not being recognized. Can I start a new pull request or do something else to make this work. Sorry for the inconvenience.

here's a screenshot of the message I got in command line

screen shot 2016-05-29 at 4 17 03 pm

@Rafase282
Copy link
Member

git push -f origin/linters is what you should type. Feel free to come to the chat and I can help yu faster.

@@ -0,0 +1,9 @@
Linting is the process of running a program that analyzes your code for programmatic and stylistic errors. A linting tool, or a linter, marks or flags any potential errors in your code such as syntax errors or incorrectly spelled variable names. This can save time and help you write better code.

Linters can be installed using `npm` or another package manager. Linters can be used from the command line by passing in files. Linters are also available as plugins for tools and sometimes they are directly integrated into editors.
Copy link

@ghost ghost May 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repetitive use of the word Linters. Try and make this flow better.

@ghost
Copy link

ghost commented May 30, 2016

@Rafase282 Does the filename look ok?

JS-Code-Linting-In-Javascript.md

@ghost ghost assigned Rafase282 May 30, 2016
@abhisekp
Copy link
Member

abhisekp commented May 31, 2016

@tanham21
File rename

- JS-Code-Linting-In-Javascript.md
+ Linters.md

@@ -0,0 +1,9 @@
Linting is the process of running a program that analyzes your code for programmatic and stylistic errors. A linting tool, or a linter, marks or flags any potential errors in your code such as syntax errors or incorrectly spelled variable names. This can save time and help you write better code.
Copy link
Member

@abhisekp abhisekp May 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a heading 1 at the top

# Linters

Linters

@abhisekp
Copy link
Member

abhisekp commented May 31, 2016

@tanham21 If possible, please add description about individual linters and their benefits or disadvantages over other linters of the same language.

Please sort the linters based on popularity and if possible, add other linters such for JSON, HTML, CSS, Sass, TypeScript, CoffeeScript, PHP and other such technologies.

@ghost
Copy link

ghost commented May 31, 2016

@abhisekp Shouldn't the file be called:

- JS-Code-Linting-In-Javascript.md
+ Javascript-Linters.md

There are other issues #610 #609 for linting in other technologies, and therefore they will be tackled in different articles.

@abhisekp
Copy link
Member

@atjonathan ah! right. Also we need an All Linters linking article.

@tanham21 Please ignore my previous file rename suggestion. This is the new name.

- JS-Code-Linting-In-Javascript.md
+ JS-Linters.md

@Rafase282
Copy link
Member

Rafase282 commented Jun 2, 2016

@tanham21 Hit me up tomorrow or tonight and and we can work on this PR.

@tanham tanham force-pushed the linters branch 4 times, most recently from 304e84e to c5c1d3a Compare June 2, 2016 16:48
@tanham tanham force-pushed the linters branch 2 times, most recently from e12da43 to 38b8ce2 Compare June 2, 2016 17:03
@Rafase282
Copy link
Member

Awesome work @tanham21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants