Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): acknowledge tracebacks in binary search tree #54789

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(curriculum): acknowledge tracebacks in binary search tree #54789

merged 3 commits into from
May 21, 2024

Conversation

zairahira
Copy link
Member

@zairahira zairahira commented May 14, 2024 •
edited

Checklist:

Related to #54647

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 14, 2024
@zairahira zairahira mentioned this pull request May 14, 2024
Open
9 tasks
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 14, 2024
@zairahira zairahira requested a review from Dario-DC May 16, 2024 10:43
@zairahira zairahira requested a review from a team May 16, 2024 15:10
ilenia-magoni
ilenia-magoni requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex may need a small adjustmend

...ith-python/learn-tree-traversal-by-building-a-binary-search-tree/65c646d4148ae3b2d1cbcac4.md Outdated Show resolved Hide resolved
@zairahira @ilenia-magoni
fix: apply suggestions from code review
c1c8bdf 
Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
ilenia-magoni
ilenia-magoni approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilenia-magoni ilenia-magoni merged commit a38ee20 into freeCodeCamp:main May 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilenia-magoni ilenia-magoni ilenia-magoni approved these changes

@Dario-DC Dario-DC Dario-DC approved these changes

Assignees
No one assigned
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zairahira @ilenia-magoni @Dario-DC @jdwilkin4