Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert output test to Playwright #54788

Merged
merged 5 commits into from
May 15, 2024
Merged

feat: convert output test to Playwright #54788

merged 5 commits into from
May 15, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 14, 2024 •
edited

  • feat: convert output test to Playwright
  • chore: remove output test

Checklist:

Closes #XXXXX

@Sembauke Sembauke requested a review from a team as a code owner May 14, 2024 11:39
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 14, 2024
ojeytonwilliams
ojeytonwilliams requested changes May 14, 2024
View reviewed changes
e2e/output.spec.ts Show resolved Hide resolved
e2e/output.spec.ts Outdated Show resolved Hide resolved
e2e/output.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/default/learn/challenges/output.ts Show resolved Hide resolved
@Sembauke @ojeytonwilliams
Apply suggestions from code review
c462cf5 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@Sembauke
Copy link
Member Author

Sorry i completely rushed this one

@Sembauke Sembauke marked this pull request as draft May 14, 2024 16:21
@Sembauke Sembauke marked this pull request as ready for review May 14, 2024 17:07
naomi-lgbt
naomi-lgbt approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is good to go

ojeytonwilliams
ojeytonwilliams approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @Sembauke! This LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit cfc5e74 into freeCodeCamp:main May 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sembauke @ojeytonwilliams @naomi-lgbt