Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(curriculum): remove __locals from tower of hanoi puzzle project #54784

Merged
merged 4 commits into from
May 15, 2024
Merged

chore(curriculum): remove __locals from tower of hanoi puzzle project #54784

merged 4 commits into from
May 15, 2024

Conversation

ilenia-magoni
Copy link
Contributor

Checklist:

Closes #XXXXX

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 14, 2024
@ilenia-magoni @Dario-DC
Apply suggestions from code review
4b1b76c 
Co-authored-by: Dario-DC <105294544+Dario-DC@users.noreply.github.com>
naomi-lgbt
naomi-lgbt requested changes May 14, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks like quite a few instances of __locals still.

@ilenia-magoni
Copy link
Contributor Author

Thank you, now I should have got all of them!

@Dario-DC Dario-DC added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label May 15, 2024
@ilenia-magoni ilenia-magoni added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating labels May 15, 2024
@Dario-DC Dario-DC enabled auto-merge (squash) May 15, 2024 10:41
naomi-lgbt
naomi-lgbt approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No locals found in this block

@Dario-DC Dario-DC merged commit 98e5ac1 into freeCodeCamp:main May 15, 2024
22 checks passed
@ilenia-magoni ilenia-magoni deleted the remove-locals-hanoi branch May 15, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sembauke Sembauke Sembauke approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@Dario-DC Dario-DC Dario-DC approved these changes

Assignees
No one assigned
Labels
new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilenia-magoni @Sembauke @naomi-lgbt @Dario-DC @camperbot