-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): acknowledge tracebacks in cipher project #54724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
label
May 9, 2024
github-actions
bot
added
the
scope: i18n
language translation/internationalization. Often combined with language type label
label
May 9, 2024
Dario-DC
requested changes
May 9, 2024
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553a7d8d05cbb1ae335a665.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553efd6ada3f42aa2d75448.md
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553f4f66099802c6ae94613.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553f4f66099802c6ae94613.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553f4f66099802c6ae94613.md
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553f4f66099802c6ae94613.md
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/65687d2f8c7ee27b0446cef3.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/65688b5a1655a7a6caede847.md
Show resolved
Hide resolved
Co-authored-by: Dario-DC <105294544+Dario-DC@users.noreply.github.com>
gikf
changed the title
fix: acknoledge tracebacks in cipher project
fix(curriculum): acknowledge tracebacks in cipher project
May 10, 2024
Dario-DC
reviewed
May 13, 2024
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553a755879b131a445e664c.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553efd6ada3f42aa2d75448.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553f4f66099802c6ae94613.md
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553f4f66099802c6ae94613.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/65688b5a1655a7a6caede847.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/65688a50e6c998a21d8e41d3.md
Outdated
Show resolved
Hide resolved
…hon/learn-string-manipulation-by-building-a-cipher/6553a755879b131a445e664c.md Co-authored-by: Dario-DC <105294544+Dario-DC@users.noreply.github.com>
Dario-DC
reviewed
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two suggestions. After that, I think it's good to go.
...uting-with-python/learn-string-manipulation-by-building-a-cipher/6553efd6ada3f42aa2d75448.md
Outdated
Show resolved
Hide resolved
...uting-with-python/learn-string-manipulation-by-building-a-cipher/65688b5a1655a7a6caede847.md
Outdated
Show resolved
Hide resolved
Dario-DC
approved these changes
May 14, 2024
9 tasks
zairahira
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new python course
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
scope: i18n
language translation/internationalization. Often combined with language type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
main
branch of freeCodeCamp.Related to #54647