Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: portfolio card style #54582

Merged
merged 7 commits into from
May 8, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Apr 30, 2024

image

The new design for the project cards. I and Ahmad decided on a new design, this design offers consistency with our news platform. Meaning, the cards look like the landing page on news. While keeping the flexibility of the old design.

We need to make sure this is what we want.

related to #48234

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Apr 30, 2024
@Sembauke Sembauke marked this pull request as ready for review May 2, 2024 06:42
@Sembauke Sembauke requested a review from a team as a code owner May 2, 2024 06:42
@ahmaxed

This comment was marked as outdated.

@Sembauke
Copy link
Member Author

Sembauke commented May 6, 2024

@ahmaxed, you are using an older version of the branch please update :)

@ahmaxed
Copy link
Member

ahmaxed commented May 7, 2024

Here is the last layout. it accommodates for larger titles and larger descriptions. I removed the button in favor of turning the whole card to a link. We do have a similar pattern in news but I am not sure if it is obvious enough.

Screenshot 2024-05-07 at 3 34 35 PM

@huyenltnguyen
Copy link
Member

We do have a similar pattern in news but I am not sure if it is obvious enough.

I just tested the PR locally and the changes look great.

I think the user would know that the title and the image are a link thanks to the pointer cursor and the hover state (the title has an underline, and the image has an overlay).

Though I'm wondering if we could/should add a border around the a. It's just that there is quite a lot of empty space in the item description, so the user could place the cursor on the empty space, without knowing it's still on the card, and accidentally clicks it. Having a border would help communicate where the card ends. (/news is a little different since the title and the image are separate links living in the same div, rather than two static elements grouped in a single a.)

Alternatively, I guess we could copy /news and have the image and the title as separate links?

@ahmaxed
Copy link
Member

ahmaxed commented May 7, 2024

Thanks for the feedback. The border is going to look strange if the description and the title exceed the height of the image. Since there is a lot of space between the two cards, finding and clicking on the desired card should be straightforward.

ahmaxed and others added 2 commits May 7, 2024 20:34
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
@huyenltnguyen huyenltnguyen merged commit 8ed2909 into freeCodeCamp:main May 8, 2024
22 checks passed
@Sembauke Sembauke deleted the feat/fix-card-styles branch May 8, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants