fix(client): english audio playback consistency #54562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform: learn
moT01
force-pushed
the
fix/english-audio-part-2
branch
from
10c3364
to
c59b3b7
Compare
moT01
force-pushed
the
fix/english-audio-part-2
branch
from
b2d90d8
to
eed2401
Compare
|
LGTM @ojeytonwilliams 👍 |
ojeytonwilliams
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audio playback in the English challenges across browsers was very inconsistent - the audio would often get cut off a little early or play a little long. Firefox and Chrome were pretty similar and both close to the intended timestamps, Safari was off by quite a bit more. You could test this PR by checking some of the challenges (not the "Dialogue" ones, since those play the whole audio and didn't have issues) on different browsers on production, and then again on this PR. The main thing is that they should be consistent. Some of the timestamp may be off a little in the challenge files because they were adjusted due to the inconsistencies. We will have to go back and adjust those later or as issues come in.
Checklist:
mainbranch of freeCodeCamp.Closes #XXXXX