Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): add animations to block 4.2 of the English Curriculum #54415

Merged
merged 12 commits into from
May 20, 2024

Conversation

DanielRosa74
Copy link
Contributor

Checklist:

@DanielRosa74 DanielRosa74 requested a review from a team as a code owner April 16, 2024 23:17
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 16, 2024
@nieldakarla nieldakarla self-assigned this Apr 22, 2024
@nieldakarla nieldakarla added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new english course English Curriculum labels Apr 22, 2024
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests need to be updated to accept the new scenes.

@naomi-lgbt naomi-lgbt added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Apr 25, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @DanielRosa74. The playback seems pretty consistent. I am still getting quite a few steps where the audio gets cut off a little early. Here's a list of the task numbers:

15-19, 
23-24, 26, 30, 36-37, 39-43, 46-47, 50-53, 58, 68-70, 72-75, 94, 104-105

I used Chrome for testing. Do you want to take a quick look at some of those and see if you are seeing the same thing? And maybe make some adjustments. They could be off a little from adjustments you made because of the inconsistencies that were present from before.

@DanielRosa74 DanielRosa74 requested a review from moT01 May 17, 2024 20:29
@DanielRosa74
Copy link
Contributor Author

This is looking good @DanielRosa74. The playback seems pretty consistent. I am still getting quite a few steps where the audio gets cut off a little early. Here's a list of the task numbers:

15-19, 
23-24, 26, 30, 36-37, 39-43, 46-47, 50-53, 58, 68-70, 72-75, 94, 104-105

I used Chrome for testing. Do you want to take a quick look at some of those and see if you are seeing the same thing? And maybe make some adjustments. They could be off a little from adjustments you made because of the inconsistencies that were present from before.

Changes made. The sentences were cutting off in those places indicated. This should fix them.

@DanielRosa74
Copy link
Contributor Author

Looks like the tests need to be updated to accept the new scenes.

Solved.

@moT01 moT01 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 20, 2024
@moT01 moT01 self-assigned this May 20, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@naomi-lgbt naomi-lgbt merged commit 6b2b220 into freeCodeCamp:main May 20, 2024
22 checks passed
@DanielRosa74 DanielRosa74 deleted the feat/4.2-Dialogues branch May 20, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants