-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(curriculum): add animations to block 4.2 of the English Curriculum #54415
feat(curriculum): add animations to block 4.2 of the English Curriculum #54415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests need to be updated to accept the new scenes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @DanielRosa74. The playback seems pretty consistent. I am still getting quite a few steps where the audio gets cut off a little early. Here's a list of the task numbers:
15-19, 23-24, 26, 30, 36-37, 39-43, 46-47, 50-53, 58, 68-70, 72-75, 94, 104-105
I used Chrome for testing. Do you want to take a quick look at some of those and see if you are seeing the same thing? And maybe make some adjustments. They could be off a little from adjustments you made because of the inconsistencies that were present from before.
curriculum/challenges/_meta/learn-how-to-discuss-popular-trends-in-technology/meta.json
Outdated
Show resolved
Hide resolved
curriculum/challenges/_meta/learn-how-to-discuss-popular-trends-in-technology/meta.json
Outdated
Show resolved
Hide resolved
curriculum/challenges/_meta/learn-how-to-discuss-popular-trends-in-technology/meta.json
Outdated
Show resolved
Hide resolved
curriculum/challenges/_meta/learn-how-to-discuss-popular-trends-in-technology/meta.json
Outdated
Show resolved
Hide resolved
curriculum/challenges/_meta/learn-how-to-discuss-popular-trends-in-technology/meta.json
Outdated
Show resolved
Hide resolved
...for-developers/learn-how-to-discuss-popular-trends-in-technology/65fdc24bcb89e8162b96d954.md
Outdated
Show resolved
Hide resolved
...for-developers/learn-how-to-discuss-popular-trends-in-technology/65fdce67e652825776635f7e.md
Outdated
Show resolved
Hide resolved
...for-developers/learn-how-to-discuss-popular-trends-in-technology/65fdcfcd986a305a20de5e57.md
Outdated
Show resolved
Hide resolved
...for-developers/learn-how-to-discuss-popular-trends-in-technology/65fdd18dada8515bcb983337.md
Outdated
Show resolved
Hide resolved
...for-developers/learn-how-to-discuss-popular-trends-in-technology/661eb97a2eb89a1ecd9a507a.md
Outdated
Show resolved
Hide resolved
Changes made. The sentences were cutting off in those places indicated. This should fix them. |
Solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Checklist:
main
branch of freeCodeCamp.