-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(Client): Clarify Progress Reset Modal #54078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RavidYael Thank you for the PR.
There are a couple of things we need to address:
- The changes should be applied directly to the existing modal, meaning there shouldn't be a new one and an old one
Modal
should be from@freecodecamp/ui
, rather than@freecodecamp/react-bootstrap
- Custom styles need to be minimal (we do want to keep the UI consistent across pages). And if there is a need for custom styles, the CSS code has to be in a CSS file rather than being applied inline
You're welcome to apply the changes, but note that we are in the process of migrating the Modal component (#52759), and we'll need to block this PR until the migration is complete.
Thank you for opening this pull request. This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you. Thank you and happy coding. |
Checklist:
main
branch of freeCodeCamp.Overview
This pull request closes Issue #53959 through the implementation of a new reset modal as discussed, including a mechanism for backward compatibility for languages yet to receive updates for the new modal translations.
Changes
translations.json
for enhanced clarity in the modal's messaging.NewResetModal
andOldResetModal
components have been created, segregating the new modal's functionality from the existing one.ResetModalRenderer
component is implemented to selectively render modals based on translation availability.Backward Compatibility
ResetModalRenderer
utilizes i18n keys to verify the presence of new modal translations.Updated Reset Modal Interface