Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional customization options #78

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Additional customization options #78

wants to merge 35 commits into from

Conversation

Armarr
Copy link

@Armarr Armarr commented May 29, 2018

  • enable_popup setting
  • fixed_label_location setting > always show big label for a more consistent user experience

There are some settings I needed in my own project.
I'm new to contributing in GitHub so feel free to point out any mistakes.

@Armarr
Additional customization options
425a5a0 
- enable_popup setting
- fixed_label_location setting > always show big label for a more consistent user experience
jamieday
jamieday reviewed Jun 30, 2018
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
sjarc and others added 21 commits February 8, 2019 11:22
add german localization for month names
0d7f980
fix mouseevent offsetX issue --> clientX
51ea867
add doubleclick event to bar, add doubleclick to listeners
2b89d5b
fix task argument of click event
c8591ca
remove long term task from example
aff49a1
add events to Arrow, hover effect, delete on click
48a80da
cleanup
0f8ebf3
make progress change, bar change, bar drag drop optional
6c09f27
add css again -.-
c145546
add js again
093b9fe
make dependencies editable
af968c2 
add dependencies by double click, add call back when editing
dependencies, update dependency map, change style when marked for
editing
make dependency edit configurable
29fe540
fixing, clean up and commenting
b6f26c8 
fixed events firing after the actual change
clean up code
commenting my changes on the framework
remove double click, add dependencies by popup
d0b94b1 
to make adding dependencies more intuitive
add localization to popup and date_utils.format
ab9a6ca
add localization to date_utils.format and popup
7c4f3cd
transfer changes to source files
8b853bb 
make dependency editing optional
fix popup overlaying bars
11eaf9c
taks with same start date cant be connected
99c721a
fixed dependency_removed event firing now
f411c52
fixed again -.-
d9eddd8
@Anurag810
Copy link
Contributor

please resolve the conflicts and make the requested changes

@Anurag810 Anurag810 self-requested a review April 26, 2019 09:01
@ayushnawani
Copy link

ayushnawani commented Aug 15, 2019 •
edited

Hi, just wanted to know when this will be merged? Thanks

@Armarr
Copy link
Author

Armarr commented Sep 12, 2019

Should be good to go now

@Anurag810 Anurag810 removed their request for review March 16, 2021 08:13
@marcelfolaron
Copy link

Merged in https://github.com/Leantime/gantt

s-aga-r
s-aga-r requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@s-aga-r s-aga-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Armarr please resolve conflicts.

@marcelfolaron
Copy link

@Armarr please resolve conflicts.

@s-aga-r I see you are merging PRs into your fork. I started that as well. Are you interested in working together on an official fork? I think this project has great potential and it's sad that it's not maintained by the owner anymore.

@s-aga-r
Copy link
Contributor

s-aga-r commented Jan 7, 2023

@Armarr please resolve conflicts.

@s-aga-r I see you are merging PRs into your fork. I started that as well. Are you interested in working together on an official fork? I think this project has great potential and it's sad that it's not maintained by the owner anymore.

@marcelfolaron I am merging the PRs in Frappe's official Gantt repository, not in my fork

@marcelfolaron
Copy link

@Armarr please resolve conflicts.

@s-aga-r I see you are merging PRs into your fork. I started that as well. Are you interested in working together on an official fork? I think this project has great potential and it's sad that it's not maintained by the owner anymore.

@marcelfolaron I am merging the PRs in Frappe's official Gantt repository, not in my fork

Thanks, even better. Glad it gets picked up again. I will send some PRs your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamieday jamieday jamieday left review comments

@s-aga-r s-aga-r s-aga-r requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Armarr @Anurag810 @ayushnawani @marcelfolaron @s-aga-r @jamieday @WurstMitBrot @anto-christo @rdeprins